[Bug 1481876] Review Request: python-pytest-shutil - A goodie-bag of unix shell and environment tools for py.test

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1481876



--- Comment #7 from Kevin Fenzi <kevin@xxxxxxxxx> ---
(In reply to Scott Talbert from comment #6)
> Package Review
> ==============
> 
> Legend:
> [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
> [ ] = Manual review needed
> 
> Summary of Issues:
> - Please check/fix the Requires

Good catch. Done. 

> - Please query upstream about the lack of LICENSE file

https://github.com/manahl/pytest-plugins/issues/68

> - Is there a reason you didn't package the latest version (1.2.11)?

Nope. This was the newest one on pypi at the time I initially packaged it. ;) 
Updating to 1.2.11 now. 

> - Your spec file doesn't match what's in the srpm

Yeah, I apparently added comments above the patch in the spec file pointing to
the upstream issue I filed on it. ;( Should be in sync now. Sorry about that. 

Spec URL:
http://www.scrye.com/~kevin/fedora/review/python-pytest-shutil/python-pytest-shutil.spec
SRPM URL:
http://www.scrye.com/~kevin/fedora/review/python-pytest-shutil/python-pytest-shutil-1.2.11-1.fc28.src.rpm

koji scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=21484310

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux