https://bugzilla.redhat.com/show_bug.cgi?id=1485335 Robert-André Mauchin <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@xxxxxxxxx --- Comment #1 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- Hello, - Please use a more meaningful name for you archive, with: Source0: https://github.com/squimrel/iso9660io/archive/%{version}/%{name}-%{version}.tar.gz - The BR for make is not needed, you can safely remove it. - You must include the LICENSE in %files: %license LICENSE - You must split the main lib from the development files. For this you need to first create a -devel subpackage: %package devel Summary: Headers files for developing with %{name} Requires: %{name}%{?_isa} = %{version}-%{release} %description devel Header files for developing applications that use %{name}. Then you add the %files section for this subpackage: the versionned *.so goes into the main lib, the unversionned .so and the headers go into the -devel subpackage: %files %license LICENSE %{_libdir}/lib%{name}.so.* %files devel %{_datarootdir}/pkgconfig/%{name}.pc %{_includedir}/%{name}.h %{_libdir}/lib%{name}.so - The changelog should contains your name and your email address: * Fri Aug 25 2017 squimrel <squimrel@xxxxxxxxxxxxxxxxx> 0.0.1-1 Also are you a member of the Packager group? Apparently you're not: https://admin.fedoraproject.org/accounts/user/view/squimrel To be able to continue forward, please apply to the Packager group. Read the doc here https://fedoraproject.org/wiki/Join_the_package_collection_maintainers I suggest you read carefully though the Guidelines: https://fedoraproject.org/wiki/Packaging:Guidelines If you do want to apply, you'll need a sponsor: please add a Blocks: FE-NEEDSPONSOR . You can then introduce yourself to fedora-devel and do informal review of other packages to show a potential sponsor that you understand the Packaging Guidelines. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
