https://bugzilla.redhat.com/show_bug.cgi?id=1484336 Lubomir Rintel <lrintel@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lrintel@xxxxxxxxxx --- Comment #3 from Lubomir Rintel <lrintel@xxxxxxxxxx> --- (In reply to Robert-André Mauchin from comment #1) Thank you for a superb review. I believe I've addressed all the points in the new version: SPEC: http://copr-dist-git.fedorainfracloud.org/cgit/lkundrak/hwinfo/libx86emu.git/plain/libx86emu.spec SRPM: https://copr-be.cloud.fedoraproject.org/results/lkundrak/hwinfo/fedora-rawhide-x86_64/00593929-libx86emu/libx86emu-1.11-2.fc28.src.rpm changes: http://copr-dist-git.fedorainfracloud.org/cgit/lkundrak/hwinfo/libx86emu.git/commit/?id=5ad2032e2a9987d3620826373b9716f30ec09f41 (In reply to Neal Gompa from comment #2) > You might want to incorporate some of what I did for libx86emu[1] and > hwinfo[2] into your specs, and I ask you consider building for EPEL7 along > with Fedora branches (so that my python-kiwi package can build EL7 images > with kiwi initrd for oemboot stuff). > > I'd also be happy to be co-maintainer if it's okay with you. :) I didn't look in detail of what's different in your SPEC file. I'd be more than happy if you co-maintained (or even better -- were the primary maintainer) of the package once it's in. Feel free to apply your changes then and make branches for whichever repo you wish. I'm filing a hwinfo review soon, and everything I wrote above applies there too. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
