https://bugzilla.redhat.com/show_bug.cgi?id=1483499 Kalev Lember <klember@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |klember@xxxxxxxxxx --- Comment #12 from Kalev Lember <klember@xxxxxxxxxx> --- Thanks for the review, Robert-André. I'll sponsor Jonas; looks like solid packaging to me. (In reply to Jonas Ådahl from comment #7) > Interesting. Is glib-compile-schemas run automatically some how? I needed to > run that locally to make code using gsettings find the corresponding schema. Yes. We have rpm file triggers in the glib2 package that automatically trigger schema recompilation when some package drops a file in %{_datadir}/glib-2.0/schemas/. It doesn't work on RHEL 7 though as the rpm there is too old, so if you want to have the package there you'll need to add the schema compilation rpm scripts back. As for the packaging here, I'd change two things. First, the complicated "%setup -q -T -b0 -n %{name}-%{version}" line shouldn't be needed here. I'd suggest to replace that with just '%autosetup' or '%autosetup -p1'. Second, you'll need to install the COPYING file (this is mandatory as per the packaging guidelines). For this, add '%license COPYING' as the first item under the %files list which then takes care of automatically copying it to /usr/share/licenses/. Anyway, welcome to the Fedora packaging world, Jonas! I've just sponsored you. Feel free to contact me when you need help figuring out how to do things :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
