https://bugzilla.redhat.com/show_bug.cgi?id=1482997 --- Comment #4 from Ben Rosser <rosser.bjr@xxxxxxxxx> --- So the package mostly looks good. I have one blocking comment and one observation: > BuildRequires: perl(ExtUtils::MakeMaker) > BuildRequires: perl > Requires: perl(Getopt::Long) > Requires: perl Instead of doing this, you should BR: perl-generators and perl-interpreter as per the Perl packaging guidelines. https://fedoraproject.org/wiki/Packaging:Perl#Build_Dependencies Then, your Requires shouldn't be needed at all. "/usr/bin/perl" will automatically get detected by RPM, since you're shipping a perl script, and perl-generators will cause Perl runtime dependencies to automatically be added to the package. > perl Makefile.PL PREFIX=/usr NO_PACKLIST=1 In case you're not aware, there is a macro for /usr: %{_prefix}. https://fedoraproject.org/wiki/Packaging:RPMMacros. While it's still strongly recommended, it's no longer actually a requirement to use it; see this section of the guidelines. https://fedoraproject.org/wiki/Packaging:Guidelines#Macros. (I generally still use the macros out of habit, though). So this is just an observation, not something that's actually blocking. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
