https://bugzilla.redhat.com/show_bug.cgi?id=1450144 Robert-André Mauchin <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |zebob.m@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |zebob.m@xxxxxxxxx Flags| |fedora-review? --- Comment #1 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- Hello, - There's two almost identical BR: BuildRequires: rubygem(rspec) BuildRequires: rubygem(rspec) >= 3 Just keep the later one with the version requirement. - There's an examples/ directory in the source files, it would be great to include it in %doc: %files %doc examples - According to the guidelines for Rubygems (https://fedoraproject.org/wiki/Packaging:Ruby#RubyGems): "There should not be Requires: ruby(release), unless you want to explicitly specify Ruby version compatibility. Automatically generated dependency on RubyGems (Requires: ruby(rubygems)) is enough" So, you should probably remove Requires: ruby(release) but instead add a Requires: ruby(rubygems) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
