Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: python-exif - Python module to extract EXIF information https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=250903 ------- Additional Comments From kevin@xxxxxxxxx 2007-08-05 19:30 EST ------- OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License (BSD) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: 7df9f94e98b6ff5da872105a11069356 EXIFpy_1.0.2.tar.gz 7df9f94e98b6ff5da872105a11069356 EXIFpy_1.0.2.tar.gz.1 See below - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package has rm -rf RPM_BUILD_ROOT at top of %install OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - No rpmlint output. OK - final provides and requires are sane. SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should have dist tag OK - Should package latest version Issues: 1. You have a typo in the 2nd line of the spec that makes it not build. 2. Your url has a typo: http://http://sourceforge.net/projects/... 3. Doesn't build under mock. Perhaps You need a BuildRequires: python-devel ? Adding that gets it building here. 4. It seems a bit odd to include the entire .py file as a doc to get the license. Perhaps you could split out the license? Are you releasing your added setup.py under the same license? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review