Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: pidgin-otr - OTR messaging for pidgin (was gaim-otr) https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=250538 ------- Additional Comments From kevin@xxxxxxxxx 2007-08-05 17:50 EST ------- OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. See below - License OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: f4ca8bc228069616d4c8fa9288af6bb5 pidgin-otr-3.1.0.tar.gz f4ca8bc228069616d4c8fa9288af6bb5 pidgin-otr-3.1.0.tar.gz.1 See below - BuildRequires correct OK - Spec handles locales/find_lang OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package has rm -rf RPM_BUILD_ROOT at top of %install OK - .la files are removed. OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. See below - No rpmlint output. OK - final provides and requires are sane SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should function as described. OK - Should have sane scriptlets. OK - Should have dist tag OK - Should package latest version Issues: 1. Per the new License guidelines I think the License: tag here should be GPLv2 (GPL version 2 only). 2. Your Provides and Obsoletes for gaim-otr don't look right to me. See: http://fedoraproject.org/wiki/Packaging/NamingGuidelines#head-3cfc1ea19d28975faad9d56f70a6ae55661d3c3d I think you should have: Provides: gaim-otr = 3.0.1-0.7.20060712cvs.fc7 Obsoletes: gaim-otr < 3.0.1-0.6.20060712cvs.fc7 3. Doesn't build here under mock. I get: checking for XML::Parser... configure: error: XML::Parser perl module is required for intltool error: Bad exit status from /var/tmp/rpm-tmp.1879 (%build) If I add a "BuildRequires: perl(XML::Parser)" it gets further and then blows up with: make[2]: Entering directory `/builddir/build/BUILD/pidgin-otr-3.1.0/po' file=`echo es | sed 's,.*/,,'`.gmo \ && rm -f $file && -o $file es.po file=`echo fr | sed 's,.*/,,'`.gmo \ && rm -f $file && -o $file fr.po /bin/sh: line 1: -o: command not found make[2]: *** [es.gmo] Error 127 make[2]: *** Waiting for unfinished jobs.... /bin/sh: line 1: -o: command not found make[2]: *** Waiting for unfinished jobs.... /bin/sh: line 1: -o: command not found make[2]: *** [fr.gmo] Error 127 make[2]: Leaving directory `/builddir/build/BUILD/pidgin-otr-3.1.0/po' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory `/builddir/build/BUILD/pidgin-otr-3.1.0' make: *** [all] Error 2 error: Bad exit status from /var/tmp/rpm-tmp.47112 (%build) Needs to also have "BuildRequires: gettext" That gets it building. 4. rpmlint says: W: pidgin-otr invalid-license GPL W: pidgin-otr invalid-license GPL W: pidgin-otr unversioned-explicit-obsoletes gaim-otr W: pidgin-otr-debuginfo invalid-license GPL Would be fixed by the issue 1 and issue 2 being fixed. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review