https://bugzilla.redhat.com/show_bug.cgi?id=1484561 --- Comment #2 from Miro Hrončok <mhroncok@xxxxxxxxxx> --- Thanks for your contribution to Fedora :) Quick peek at the specfile: 1) this is there twice: BuildRequires: systemd 2) The %post, %preun, %postun as written would happen on the "main" package python-ludolph, but there is not such package built here, use %post python3-%{pypi_name} etc. to make them work with the package owning the %{_unitdir}/ludolph.service file: %post python3-%{pypi_name} %systemd_post ludolph.service ... You would also need to do this for the python2 subpackage, but see 3. 3) The %{_unitdir}/ludolph.service generally shouldn't be in both subpackages. The service calls /usr/bin/ludolph and that is only in the python3 subpackage. Having the file in both packages thus makes no sense. Also, a common file across 2 subpackages is almost always painful. I.e. if both packages are installed, they need to be in the same version-release, otherwise dnf/rpm would scream on us "File xyz form python2-... conflicts with file from python3-..." - rule of thumb -> avoid it when possible. Here it is possible and also easy. if not avoidable, create a common subpackage required by both subpackages needing the file (not relevant here). 4) The ghost config file is also shared and honestly I don't know if shared ghost files are problematic or not. Will investigate. 5) the systemd service file talks about /run/ludolph/ludolph.pid - and the package doesn't own /run/ludolph. I've looked at avahi (similar case), where /run/avahi-daemon/ belongs to the avahi package and it is a ghost (%ghost %dir %{_localstatedir}/run/avahi-daemon). The file inside does not belong to anything. Now I don't have a guideline here to quite, but what avahi does seems reasonable and others do it in similar way. (And the following are more curious questions, based of what I've seen last time we talked about this IRL.) 6) the package seems not to do anything about tmpfiles.d. Does it work? 7) no selinux problems? Otherwise the specfile look legible. Will do a full review once we finish this. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
