https://bugzilla.redhat.com/show_bug.cgi?id=1484336 Robert-André Mauchin <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |zebob.m@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |zebob.m@xxxxxxxxx Flags| |fedora-review? --- Comment #1 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- Hello, - The Group: tag is not needeed in Fedora, please remove it (twice). See: https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections - You -devel subpackage must depend on the main package: Requires: %{name}%{?_isa} = %{version}-%{release} - Change make %{?_smp_mflags} into %make_build - Please change Source0: to: Source0: https://github.com/wfeldt/libx86emu/archive/%{version}/%{name}-%{version}.tar.gz - You forgot to run ldconfig for you *.so files. See: https://fedoraproject.org/wiki/Packaging:Guidelines#Shared_Libraries %post -p /sbin/ldconfig %postun -p /sbin/ldconfig -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
