[Bug 1480973] Review Request: golang-github-alecthomas-kingpin - A Go command line and flag parser

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1480973

Robert-André Mauchin <zebob.m@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |zebob.m@xxxxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |zebob.m@xxxxxxxxx
              Flags|                            |fedora-review?



--- Comment #1 from Robert-André Mauchin <zebob.m@xxxxxxxxx> ---
Hello,

 - The _examples/ folder should go in %doc:

%doc _examples

And remove it from devel.file-list:

for file in $(find . -iname "*.go" \! -iname "*_test.go" \! -path
"./_examples/*")  ; do


 - Change:

%dir %{gopath}/src/%{import_path}

to

%dir %{gopath}/src/%{import_path}/cmd

And remove: %{gopath}/src/%{import_path2}

(The import_path was already listed but the subdirectory cmd was not)


 - Missing dependency:

DEBUG util.py:450:  No matching package to install:
'golang(github.com/alecthomas/assert)'
→ Bug #1480971: accepted but not yet built. It seems you haven't yet requested
the repo to be created with fedrepo-req. Please do it so we can move forward.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux