https://bugzilla.redhat.com/show_bug.cgi?id=1483339 --- Comment #4 from Neal Gompa <ngompa13@xxxxxxxxx> --- > 1) Your package isn't for the latest version (v9.10.6, package is for v9.10.4). Latest version came out yesterday morning! It was latest as of when I submitted this review request on Saturday. Upstream makes releases fairly aggressively. *shrugs* > 2) The Release tag looks strange. Why is it not just "1%{?dist}"? It's at 0%{?dist}.X for the COPR/review only. When I import it, I bump it to 1. That way I don't have any funny business and everything is nicely upgradable. > 3) Sorting the (Build)Requires and Provides alphabetically would be appreciated. I'll see what I can do about that, but, there's a lot... > Additionally, you might consider naming the main package "kiwi.spec", since that's the name of the program and the "main" package anyway. I thought about this, but the problem with that is that I can't make kiwi subpackage noarch then. The source package has to be archful since some subpackages are archful. And we do provide a usable Python module (pythonX-kiwi), so I figured it's fine to be python-kiwi for the source package. It matches what openSUSE does for their package, too. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
