[Bug 1483963] Review Request: nuvola-app-jupiter-broadcasting - Jupiter Broadcasting plugin for Nuvola Player

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1483963

Robert-André Mauchin <zebob.m@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |zebob.m@xxxxxxxxx
              Flags|                            |fedora-review?



--- Comment #1 from Robert-André Mauchin <zebob.m@xxxxxxxxx> ---
Hello,


 - You should use the %configure macro instead of ./configure
--prefix=%{_prefix}

 - DESTDIR=%{buildroot} is not needed after %make_install

 - You can actually fix the typo: linux → Linux

 - Use this for Source0:

Source0:       
https://github.com/tiliado/%{name}/archive/%{version}/%{name}-%{version}.tar.gz

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux