Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: sepostgresql - Security-Enhanced PostgreSQL https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249522 ------- Additional Comments From kaigai@xxxxxxxxxxxx 2007-08-05 11:20 EST ------- (In reply to comment #13) > * Patch0 > -------------------------------------------------- > Patch0: sepostgresql-%{version}-%{release}.patch > -------------------------------------------------- > - Please don't write in this way. This surely > fails on F-7 FC-6 (i.e. except for rawhide) because > release is defined as: > -------------------------------------------------- > Release: 0.409%{?sepgextension}%{?dist} > -------------------------------------------------- Is it possible to use an immediate version identifier instead of "${version}-% {release}", like "Patch0: sepostgresql-0.409.patch" ? If not so, we cannot identify differenct patches. > * AutoProv: no > - Why is this needed? It got unnecessary in the current version. I'll remove it. > * CFLAGS > -------------------------------------------------- > CFLAGS=`echo $CFLAGS|xargs -n 1|grep -v ffast-math|xargs -n 100` > -------------------------------------------------- > - This is redundant because Fedora's CFLAGS does not contain > -ffast-math It's just a copy from postgresql.spec. I'll remove it. > * Macros > - Please use macros correctly. > /var -> %_localstatedir > /usr/sbin -> %_sbindir The translation of "/usr/sbin -> %_sbindir" also targets /usr/sbin/semodule? In my understanding, the location of external commands don't have any relationship with %_prefix of sepostgresql. I don't have any specific note for the rest of your comments. I'll fix them. Please wait for updating the specfile. Thanks, -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review