https://bugzilla.redhat.com/show_bug.cgi?id=1471056 --- Comment #3 from Marc Dequènes (Duck) <duck@xxxxxxxxxx> --- Thanks Robert-André for the review. As for the version, the following fix was needed to make the service usable at all: https://github.com/roehling/postsrsd/pull/65 I should have made it clearer in the changelog and will fix this. You're right, base64 is part of coreutils. The following page tells me a BuildRequires on it is unnecessary: https://fedoraproject.org/wiki/HOWTOFindMissingBuildRequires It is ok for this package, nevertheless this is really not satisfying. How are we supposed to know the list of these packages. Someone on the Internet suggested it could be packages in group 'Core' but got no interesting reply. I can't find more documentation on this, could point at the canonical source of info? As for SELinux, could you tell me where these information come from, it is not in the Fedora Packaging guidelines? So the fishy part was about allowing the scritlets to work on machines without SELinux activated. Is Fedora officially not supporting such configurations? Are these scriplets requires really necessary, it looks to me packages from a base installation, and also in the 'Core' group? I did not know fixfiles, really practical; I would still need to call restorecon manually for /etc/postsrsd.secret as it is generated and not in %files. Or is there another way? Also calling semodule only at first install seems not a good idea. The daemon might change and require new rules, so it's safer to rebuild after each upgrade to avoid breaking the service. Same for fixfiles. And then same for restarting the service. Am I wrong? Also what is "|| :"? Seems to behave like "|| true" but I don't find it very readable (might depend on your font size though). So I'm going to push fixes which are well understood. The rest would come soon. Regards. \_o< -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
