[Bug 1483499] Review Request: gnome-remote-desktop - Remote desktop server for GNOME

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1483499

Robert-André Mauchin <zebob.m@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |zebob.m@xxxxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |zebob.m@xxxxxxxxx
              Flags|                            |fedora-review?



--- Comment #2 from Robert-André Mauchin <zebob.m@xxxxxxxxx> ---
Hello,

 - I'd prefer you use spaces instead of tabs.

 - systemd user unit files must be placed in %{_userunitdir}, not
%{_libdir}/systemd/user/ because they are system independent, otherwise libdir
would resolve to lib64. See https://fedoraproject.org/wiki/Packaging:Systemd I
don't know how meson work and if you can change the location of the unit file
with a command line argument, if you can't, move it in %install:

%{__mkdir_p} $RPM_BUILD_ROOT/%{_userunitdir}
%{__mv} $RPM_BUILD_ROOT/%{_libdir}/systemd/user/gnome-remote-desktop.service
$RPM_BUILD_ROOT/%{_userunitdir}/gnome-remote-desktop.service

Then in your %files:

%{_userunitdir}/gnome-remote-desktop.service

 - You also need to use systemd scriplets in %post, %preun, %postun: see
https://fedoraproject.org/wiki/Packaging:Scriptlets?rd=Packaging:ScriptletSnippets#Systemd

%post
%systemd_post %{name}.service


%preun
%systemd_preun %{name}.service


%postun
%systemd_postun_with_restart %{name}.service


 - You also need to add a BR with a special macro:

%{?systemd_requires}
BuildRequires: systemd

 - The description should be split in multiples lines in order to be below <80
characters

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux