https://bugzilla.redhat.com/show_bug.cgi?id=1483296 Robert-André Mauchin <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@xxxxxxxxx --- Comment #1 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- Hello, Some similar issues as before: - You must post both SPEC URL and SRPM URL. It's used by fedora review to fetch the files from a bug number. - The latest version is 4.3.4, not 4.3.3 - Just use: %global repo dde-dock , no need for project - The changelog version is incorrect, you shouldn't include the git revision for a stable release - Why did you add a Provides and Obsoletes, this doesn't seem useful since it's not a renamed package. - Removes the Requires which are commented - Use pkgconfig where you can: BuildRequires: pkgconfig(dtkbase) BuildRequires: pkgconfig(dframeworkdbus) BuildRequires: pkgconfig(gsettings-qt) BuildRequires: pkgconfig(gtk+-2.0) BuildRequires: pkgconfig(xtst) BuildRequires: qt5-linguist BuildRequires: pkgconfig(Qt5) BuildRequires: pkgconfig(Qt5X11Extras) BuildRequires: pkgconfig(Qt5Svg) BuildRequires: pkgconfig(xcb-ewmh) BuildRequires: pkgconfig(xcb-image) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
