https://bugzilla.redhat.com/show_bug.cgi?id=1483297 Robert-André Mauchin <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@xxxxxxxxx Depends On| |1483296 --- Comment #1 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- Hello, Some similar issues as before: - You must post both SPEC URL and SRPM URL. It's used by fedora review to fetch the files from a bug number. - The latest version is 4.2.5.4, not 4.2.5 - Just use: %global repo dde-control-center , no need for %project - Use pkgconfig where you can: BuildRequires: pkgconfig(dtkbase) BuildRequires: deepin-dock-devel BuildRequires: pkgconfig(dframeworkdbus) BuildRequires: pkgconfig(gsettings-qt) BuildRequires: pkgconfig(geoip) BuildRequires: qt5-linguist BuildRequires: pkgconfig(Qt5) BuildRequires: pkgconfig(Qt5Svg) BuildRequires: pkgconfig(Qt5Multimedia) BuildRequires: pkgconfig(Qt5X11Extras) - You forgot to do the desktop-file validation: %check desktop-file-validate %{buildroot}/%{_datadir}/applications/%{repo}.desktop - Need deepin-dock-devel, so I'm adding a dependency on #1483296 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1483296 [Bug 1483296] Review Request: deepin-dock - Deepin desktop environment Dock module -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
