https://bugzilla.redhat.com/show_bug.cgi?id=1483300 Robert-André Mauchin <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |zebob.m@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |zebob.m@xxxxxxxxx Flags| |fedora-review? --- Comment #1 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- Hello, You need to post both the SPEC URL: and the SRPM URL. You should use pkg config for your BR. Here is the full list: BuildRequires: pkgconfig(dbus-1) BuildRequires: pkgconfig(dtkbase) BuildRequires: pkgconfig(egl) BuildRequires: pkgconfig(gl) BuildRequires: pkgconfig(Qt5OpenGLExtensions) BuildRequires: pkgconfig(Qt5Svg) BuildRequires: pkgconfig(Qt5X11Extras) BuildRequires: pkgconfig(Qt5Xdg) BuildRequires: pkgconfig(ice) BuildRequires: pkgconfig(sm) BuildRequires: pkgconfig(x11) BuildRequires: pkgconfig(xext) BuildRequires: pkgconfig(xi) BuildRequires: pkgconfig(xrender) BuildRequires: pkgconfig(atk) BuildRequires: pkgconfig(cairo) BuildRequires: pkgconfig(fontconfig) BuildRequires: pkgconfig(freetype2) BuildRequires: pkgconfig(gtk+-2.0) BuildRequires: pkgconfig(glib-2.0) BuildRequires: pkgconfig(gdk-pixbuf-2.0) BuildRequires: pkgconfig(libinput) BuildRequires: pkgconfig(mtdev) BuildRequires: pkgconfig(pango) BuildRequires: pkgconfig(xcb-ewmh) BuildRequires: pkgconfig(xcb-image) BuildRequires: pkgconfig(xcb-keysyms) BuildRequires: pkgconfig(xcb-renderutil) BuildRequires: pkgconfig(xcb) BuildRequires: pkgconfig(xkbcommon-x11) BuildRequires: pkgconfig(xkbcommon) - You need to package the latest version, which is 0.2.3, not 0.2.1. - The version in your changelog is wront, you don't need .git2cd7432 if you're packaging a stable release, it's only for development snapshot. - I don't get why you define two times the same variable under different names: %global project qt5integration %global repo %{project} Just keep: %global repo qt5integration - There are parts of the code which are not under GPLv3: BSD (3 clause) -------------- qt5integration-0.2.3/styles/main.cpp qt5integration-0.2.3/styles/norwegianwoodstyle.cpp qt5integration-0.2.3/styles/norwegianwoodstyle.h qt5integration-0.2.3/styles/widgetgallery.cpp qt5integration-0.2.3/styles/widgetgallery.h GPL (v3 or later) ----------------- qt5integration-0.2.3/dstyleplugin/colorutils.cpp qt5integration-0.2.3/dstyleplugin/colorutils.h qt5integration-0.2.3/dstyleplugin/comboboxhelper.cpp qt5integration-0.2.3/dstyleplugin/common.h qt5integration-0.2.3/dstyleplugin/commonhelper.cpp qt5integration-0.2.3/dstyleplugin/commonhelper.h qt5integration-0.2.3/dstyleplugin/dstyleplugin.cpp qt5integration-0.2.3/dstyleplugin/dstyleplugin.h qt5integration-0.2.3/dstyleplugin/framehelper.cpp qt5integration-0.2.3/dstyleplugin/geometryutils.cpp qt5integration-0.2.3/dstyleplugin/geometryutils.h qt5integration-0.2.3/dstyleplugin/lineedithelper.cpp qt5integration-0.2.3/dstyleplugin/paletteextended.cpp qt5integration-0.2.3/dstyleplugin/paletteextended.h qt5integration-0.2.3/dstyleplugin/progressbarhelper.cpp qt5integration-0.2.3/dstyleplugin/pushbuttonhelper.cpp qt5integration-0.2.3/dstyleplugin/sliderhelper.cpp qt5integration-0.2.3/dstyleplugin/style.cpp qt5integration-0.2.3/dstyleplugin/style.h qt5integration-0.2.3/platformplugin/dforeignplatformwindow.h qt5integration-0.2.3/platformplugin/dforeignplatformwindow_x11.cpp qt5integration-0.2.3/platformplugin/dframewindow.cpp qt5integration-0.2.3/platformplugin/dframewindow.h qt5integration-0.2.3/platformplugin/dplatformbackingstorehelper.cpp qt5integration-0.2.3/platformplugin/dplatformbackingstorehelper.h qt5integration-0.2.3/platformplugin/dplatformopenglcontexthelper.cpp qt5integration-0.2.3/platformplugin/dplatformopenglcontexthelper.h qt5integration-0.2.3/platformplugin/dplatformwindowhelper.cpp qt5integration-0.2.3/platformplugin/dplatformwindowhelper.h qt5integration-0.2.3/platformplugin/dwmsupport.h qt5integration-0.2.3/platformplugin/windoweventhook.cpp qt5integration-0.2.3/platformplugin/windoweventhook.h LGPL (v2.1 or v3) ----------------- qt5integration-0.2.3/dstyleplugin/dstyleanimation.cpp qt5integration-0.2.3/dstyleplugin/dstyleanimation.h qt5integration-0.2.3/platformplugin/main.cpp MIT/X11 (BSD like) ------------------ qt5integration-0.2.3/platformplugin/LICENSE Please add them in the Licence: tag and add a comment detailing which licenses cover which parts of the code. - During the build of your package, it requires an Internet access to git clone a repository. You won't be able to do this on Koji because networking is disabled, you'll get the following error: Checking for dtkwidget... Cloning into 'libqt5xcbqpa-dev'... fatal: unable to access 'https://cr.deepin.io/libqt5xcbqpa-dev/': Could not resolve host: cr.deepin.io Project ERROR: clone libqt5xcbqpa header sources failed So you must find an alternate solution to include libqt5xcbqpa. I suggest you to add this repository in a tar.gz as Source1, with detailed instruction on how you build the tar.gz: # git clone https://cr.deepin.io/libqt5xcbqpa-dev/ # tar -cf libqt5xcbqpa-dev.tar.gz libqt5xcbqpa-dev Source1: libqt5xcbqpa-dev.tar.gz Then in %prep, after %setup, you just unpack the tar.gz and move it where the build script expects it: %{__tar} xf %{SOURCE1} %{__mv} libqt5xcbqpa-dev platformplugin/. With this, you'll be able to build it in Koji later. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
