https://bugzilla.redhat.com/show_bug.cgi?id=1483202 Robert-André Mauchin <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+ --- Comment #3 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- Not an issue per se but i would strongly prefer if you kept the original commit here instead of putting the version: %global commit 9858af9cca4c73576f0b8c6609a396eb0878023c And then change Source0 to: Source0: https://%{provider_prefix}/archive/v%{version}/%{repo}-%{version}.tar.gz Otherwise commit, and shortcommit which is based upon it, won't reflect correct values, even if it "works". Otherwise it's good, package accepted. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
