[Bug 1483129] golang-github-neurosnap-sentences - Multilingual command line sentence tokenizer in Golang

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1483129



--- Comment #3 from Athos Ribeiro <athoscribeiro@xxxxxxxxx> ---
What if some project decides to

import "github.com/neurosnap/sentences" ?

Note that upstream does so, here [1] and here [2]. So I see 3 possible options:

a) packaging this under both namespaces
b) package only one of the namespaces and patch the source code and
dependencies to stick to only one namespace

(a) seems to be a good option at first, but then if we pay closer attention to
the namespace in 'gopkg.in/neurosnap/sentences.v1', it carries the package
major version with it. So whenever they decide to bump the major version, we
would need to package it again and retire the old namespace. I believe this is
not a good approach for software distribution. That's why I opted to go with
(b).

If you prefer, we could go with (a), but packaging only
gopkg.in/neurosnap/sentences.v1 is not possible because upstream itself would
not build without the github package. A third option (c) would be to send a
patch upstream to make [1] and [2] import gopkg.in/neurosnap/sentences.v1

But then this would still be a problem if some other project we want to package
ever decides to import the github path for some reason (I do not have a
solution for this).

[1]
https://github.com/neurosnap/sentences/blob/eaa759e51378560dd9b545de7502d7c92c5166a7/_cmd/sentences/main.go#L10

[2]
https://github.com/neurosnap/sentences/blob/c4a4a02cd25ad0d1b1b623459a63fbeceae6c375/sentences_test.go#L8

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux