https://bugzilla.redhat.com/show_bug.cgi?id=1452958 Robert-André Mauchin <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@xxxxxxxxx --- Comment #6 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- Hi, - The Group: tag is not needed in Fedora. See: https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections - You didn't remove the line: Provides: python3-%{name} = %{version} which is not useful with %{?python_provide:%python_provide python%{python3_pkgversion}-%{srcname}} - You've got a whole bunch of rpmlint error because some of Python files contain a shebang: Checking: sasutils-0.3.8-1.fc27.noarch.rpm sasutils-0.3.8-1.fc27.src.rpm sasutils.noarch: E: wrong-script-interpreter /usr/lib/python3.6/site-packages/sasutils/cli/sas_counters.py /usr/bin/env python sasutils.noarch: E: non-executable-script /usr/lib/python3.6/site-packages/sasutils/cli/sas_counters.py 644 /usr/bin/env python sasutils.noarch: E: wrong-script-interpreter /usr/lib/python3.6/site-packages/sasutils/cli/sas_devices.py /usr/bin/env python sasutils.noarch: E: non-executable-script /usr/lib/python3.6/site-packages/sasutils/cli/sas_devices.py 644 /usr/bin/env python sasutils.noarch: E: wrong-script-interpreter /usr/lib/python3.6/site-packages/sasutils/cli/sas_discover.py /usr/bin/env python sasutils.noarch: E: non-executable-script /usr/lib/python3.6/site-packages/sasutils/cli/sas_discover.py 644 /usr/bin/env python sasutils.noarch: E: wrong-script-interpreter /usr/lib/python3.6/site-packages/sasutils/cli/sas_mpath_snic_alias.py /usr/bin/env python sasutils.noarch: E: non-executable-script /usr/lib/python3.6/site-packages/sasutils/cli/sas_mpath_snic_alias.py 644 /usr/bin/env python sasutils.noarch: E: wrong-script-interpreter /usr/lib/python3.6/site-packages/sasutils/cli/sas_sd_snic_alias.py /usr/bin/env python sasutils.noarch: E: non-executable-script /usr/lib/python3.6/site-packages/sasutils/cli/sas_sd_snic_alias.py 644 /usr/bin/env python sasutils.noarch: E: wrong-script-interpreter /usr/lib/python3.6/site-packages/sasutils/cli/ses_report.py /usr/bin/env python sasutils.noarch: E: non-executable-script /usr/lib/python3.6/site-packages/sasutils/cli/ses_report.py 644 /usr/bin/env python sasutils.noarch: W: no-manual-page-for-binary sas_mpath_snic_alias sasutils.noarch: W: no-manual-page-for-binary sas_sd_snic_alias 2 packages and 0 specfiles checked; 12 errors, 2 warnings. That's a no-no in Fedora. Remove them in %prep with something like: find -name \*.py | xargs sed -i -e '1 {/^#!/d} -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
