https://bugzilla.redhat.com/show_bug.cgi?id=1475791 --- Comment #5 from Fabio Valentini <decathorpe@xxxxxxxxx> --- I've found some minor issues: 1) Please don't remove the commit and shortcommit variables generated by gofed. They are used to do automatic version tracking of golang packages in fedora, even if they aren't part of the version string. You can include something like this (look at some of my golang packages, e.g. golang-github-calmh-du) to clarify that the version is exactly this commit: %global commit b24eb346a94c3ba12c1da1e564dbac1b498a77ce %global shortcommit %(c=%{commit}; echo ${c:0:7}) # commit b24eb346a94c3ba12c1da1e564dbac1b498a77ce == version 1.1.1 2) Please don't use the "ugly" Source0 URL. There's a really nice way to get tarballs of tags (without doing the #/XXX.tar.gz hack): Source0: https://%{provider_prefix}/archive/v%{version}/%{repo}-%{version}.tar.gz This generates a tarball of the commit tagged with "v%{version}" with the name "%{project}-%{version}.tar.gz" - which is exactly what you want, without hacks. See (under GitHub): https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/SourceURL#Git_Tags PS: For some golang projects, you might consider naming the tarball "%{project}-%{repo}.tar.gz" in the Source URL, especially if the name %{repo} is ambiguous, or if there's already a package with that name. That way you won't run into possible collisions in the source lookaside cache. It's not an issue with this package, but keep it in mind. Otherwise: Package Review ============== [x]: Package complies to the Packaging Guidelines Please fix the 2 issues I pointed out, then the package is ready for approval. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
