Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: sundials - nonlinear differential/algebraic solvers from LLNL https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249034 ------- Additional Comments From debarshi.ray@xxxxxxxxx 2007-08-04 03:50 EST ------- (In reply to comment #28) > * Your point about macros is rather pedantic. I don't see the value in going > through another cycle to correct this. It may seem pedantic when we see it in the perspective of one package. Take into consideration a 4000 packages, and suddenly such things become important. Any way "consisten use of macros" is a "must" item in http://fedoraproject.org/wiki/Packaging/ReviewGuidelines and I would like you to do something about it. In any case we have to wait for the Licensing issue to be resolved. > * The comment about parallel builds indicates that I tried to include support > for nvec_parallel but failed due to an build error. From what I could tell, it > *seemed* to need some patching of the upstream code. For the moment I will not > be providing parallel support but would hope to do so in future. Note that the > Debian package of SUNDIALS does not include parallel either. Ok. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review