https://bugzilla.redhat.com/show_bug.cgi?id=1474958 --- Comment #17 from Antonio Trande <anto.trande@xxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - lammps-openmpi and lammps-mpich do not need 'Buildrequires:' - 'Requires: mpich or openmpi' are lines for 'lammps-openmpi' or 'lammps-mpich' respectively - lammps-openmpi and lammps-mpich do not provide their own LICENSE ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL", "GPL (v2 or later)", "GPL (v3 or later)", "Unknown or generated", "*No copyright* GPL", "MIT/X11 (BSD like)", "SIL (v1.1)", "BSD (unspecified)", "GPL (v2 or later) (with incorrect FSF address)", "*No copyright* CC0", "BSD (3 clause)", "BSD (2 clause)", "*No copyright* MIT/X11 (BSD like)". 5522 files have unknown license. Detailed output of licensecheck in /home/sagitter/1474958-lammps/licensecheck.txt [!]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [!]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [!]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in lammps- openmpi , lammps-mpich , lammps-headers , lammps-mpich-devel , lammps- openmpi-devel , lammps-debuginfo [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Scriptlets must be sane, if used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: lammps-20170811-4.fc27.x86_64.rpm lammps-openmpi-20170811-4.fc27.x86_64.rpm lammps-mpich-20170811-4.fc27.x86_64.rpm python3-lammps-20170811-4.fc27.x86_64.rpm lammps-headers-20170811-4.fc27.x86_64.rpm lammps-devel-20170811-4.fc27.x86_64.rpm lammps-mpich-devel-20170811-4.fc27.x86_64.rpm lammps-openmpi-devel-20170811-4.fc27.x86_64.rpm lammps-debuginfo-20170811-4.fc27.x86_64.rpm lammps-20170811-4.fc27.src.rpm lammps.x86_64: W: spelling-error %description -l en_US biomolecules -> bio molecules, bio-molecules, molecules lammps.x86_64: W: spelling-error %description -l en_US mesoscopic -> microscopic lammps.x86_64: W: spelling-error %description -l en_US meso -> mes, meson, mess lammps.x86_64: W: shared-lib-calls-exit /usr/lib64/liblammps.so.0 exit@GLIBC_2.2.5 lammps.x86_64: W: hidden-file-or-dir /usr/lib/.build-id lammps.x86_64: W: hidden-file-or-dir /usr/lib/.build-id lammps.x86_64: W: no-manual-page-for-binary lmp lammps-openmpi.x86_64: W: spelling-error %description -l en_US biomolecules -> bio molecules, bio-molecules, molecules lammps-openmpi.x86_64: W: spelling-error %description -l en_US mesoscopic -> microscopic lammps-openmpi.x86_64: W: spelling-error %description -l en_US meso -> mes, meson, mess lammps-openmpi.x86_64: W: shared-lib-calls-exit /usr/lib64/openmpi/lib/liblammps.so.0 exit@GLIBC_2.2.5 lammps-openmpi.x86_64: W: no-documentation lammps-openmpi.x86_64: W: hidden-file-or-dir /usr/lib/.build-id lammps-openmpi.x86_64: W: hidden-file-or-dir /usr/lib/.build-id lammps-openmpi.x86_64: E: library-without-ldconfig-postin /usr/lib64/openmpi/lib/liblammps.so.0 lammps-openmpi.x86_64: E: library-without-ldconfig-postun /usr/lib64/openmpi/lib/liblammps.so.0 lammps-mpich.x86_64: W: spelling-error %description -l en_US biomolecules -> bio molecules, bio-molecules, molecules lammps-mpich.x86_64: W: spelling-error %description -l en_US mesoscopic -> microscopic lammps-mpich.x86_64: W: spelling-error %description -l en_US meso -> mes, meson, mess lammps-mpich.x86_64: W: shared-lib-calls-exit /usr/lib64/mpich/lib/liblammps.so.0 exit@GLIBC_2.2.5 lammps-mpich.x86_64: W: no-documentation lammps-mpich.x86_64: W: hidden-file-or-dir /usr/lib/.build-id lammps-mpich.x86_64: W: hidden-file-or-dir /usr/lib/.build-id lammps-mpich.x86_64: E: library-without-ldconfig-postin /usr/lib64/mpich/lib/liblammps.so.0 lammps-mpich.x86_64: E: library-without-ldconfig-postun /usr/lib64/mpich/lib/liblammps.so.0 python3-lammps.x86_64: W: spelling-error %description -l en_US biomolecules -> bio molecules, bio-molecules, molecules python3-lammps.x86_64: W: spelling-error %description -l en_US mesoscopic -> microscopic python3-lammps.x86_64: W: spelling-error %description -l en_US meso -> mes, meson, mess python3-lammps.x86_64: W: no-documentation lammps-headers.x86_64: W: spelling-error %description -l en_US biomolecules -> bio molecules, bio-molecules, molecules lammps-headers.x86_64: W: spelling-error %description -l en_US mesoscopic -> microscopic lammps-headers.x86_64: W: spelling-error %description -l en_US meso -> mes, meson, mess lammps-headers.x86_64: W: no-documentation lammps-devel.x86_64: W: spelling-error %description -l en_US biomolecules -> bio molecules, bio-molecules, molecules lammps-devel.x86_64: W: spelling-error %description -l en_US mesoscopic -> microscopic lammps-devel.x86_64: W: spelling-error %description -l en_US meso -> mes, meson, mess lammps-devel.x86_64: W: only-non-binary-in-usr-lib lammps-devel.x86_64: W: no-documentation lammps-mpich-devel.x86_64: W: spelling-error %description -l en_US biomolecules -> bio molecules, bio-molecules, molecules lammps-mpich-devel.x86_64: W: spelling-error %description -l en_US mesoscopic -> microscopic lammps-mpich-devel.x86_64: W: spelling-error %description -l en_US meso -> mes, meson, mess lammps-mpich-devel.x86_64: W: only-non-binary-in-usr-lib lammps-mpich-devel.x86_64: W: no-documentation lammps-openmpi-devel.x86_64: W: spelling-error %description -l en_US biomolecules -> bio molecules, bio-molecules, molecules lammps-openmpi-devel.x86_64: W: spelling-error %description -l en_US mesoscopic -> microscopic lammps-openmpi-devel.x86_64: W: spelling-error %description -l en_US meso -> mes, meson, mess lammps-openmpi-devel.x86_64: W: only-non-binary-in-usr-lib lammps-openmpi-devel.x86_64: W: no-documentation lammps-debuginfo.x86_64: E: useless-provides debuginfo(build-id) lammps.src: W: spelling-error %description -l en_US biomolecules -> bio molecules, bio-molecules, molecules lammps.src: W: spelling-error %description -l en_US mesoscopic -> microscopic lammps.src: W: spelling-error %description -l en_US meso -> mes, meson, mess 10 packages and 0 specfiles checked; 5 errors, 47 warnings. Rpmlint (debuginfo) ------------------- Checking: lammps-debuginfo-20170811-4.fc27.x86_64.rpm lammps-openmpi-debuginfo-20170811-4.fc27.x86_64.rpm lammps-mpich-debuginfo-20170811-4.fc27.x86_64.rpm lammps-debuginfo.x86_64: E: useless-provides debuginfo(build-id) lammps-openmpi-debuginfo.x86_64: E: useless-provides debuginfo(build-id) lammps-openmpi-debuginfo.x86_64: E: debuginfo-without-sources lammps-mpich-debuginfo.x86_64: E: useless-provides debuginfo(build-id) lammps-mpich-debuginfo.x86_64: E: debuginfo-without-sources 3 packages and 0 specfiles checked; 5 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory lammps-openmpi.x86_64: W: spelling-error %description -l en_US biomolecules -> bio molecules, bio-molecules, molecules lammps-openmpi.x86_64: W: spelling-error %description -l en_US mesoscopic -> microscopic lammps-openmpi.x86_64: W: spelling-error %description -l en_US meso -> mes, meson, mess lammps-openmpi.x86_64: W: unused-direct-shlib-dependency /usr/lib64/openmpi/lib/liblammps.so.0 /lib64/libquadmath.so.0 lammps-openmpi.x86_64: W: shared-lib-calls-exit /usr/lib64/openmpi/lib/liblammps.so.0 exit@GLIBC_2.2.5 lammps-openmpi.x86_64: W: no-documentation lammps-openmpi.x86_64: E: library-without-ldconfig-postin /usr/lib64/openmpi/lib/liblammps.so.0 lammps-openmpi.x86_64: E: library-without-ldconfig-postun /usr/lib64/openmpi/lib/liblammps.so.0 lammps-debuginfo.x86_64: E: useless-provides debuginfo(build-id) lammps-headers.x86_64: W: spelling-error %description -l en_US biomolecules -> bio molecules, bio-molecules, molecules lammps-headers.x86_64: W: spelling-error %description -l en_US mesoscopic -> microscopic lammps-headers.x86_64: W: spelling-error %description -l en_US meso -> mes, meson, mess lammps-headers.x86_64: W: no-documentation lammps.x86_64: W: spelling-error %description -l en_US biomolecules -> bio molecules, bio-molecules, molecules lammps.x86_64: W: spelling-error %description -l en_US mesoscopic -> microscopic lammps.x86_64: W: spelling-error %description -l en_US meso -> mes, meson, mess lammps.x86_64: W: unused-direct-shlib-dependency /usr/lib64/liblammps.so.0 /lib64/libquadmath.so.0 lammps.x86_64: W: shared-lib-calls-exit /usr/lib64/liblammps.so.0 exit@GLIBC_2.2.5 lammps.x86_64: W: no-manual-page-for-binary lmp python3-lammps.x86_64: W: spelling-error %description -l en_US biomolecules -> bio molecules, bio-molecules, molecules python3-lammps.x86_64: W: spelling-error %description -l en_US mesoscopic -> microscopic python3-lammps.x86_64: W: spelling-error %description -l en_US meso -> mes, meson, mess python3-lammps.x86_64: W: no-documentation lammps-mpich-debuginfo.x86_64: E: useless-provides debuginfo(build-id) lammps-mpich-debuginfo.x86_64: E: debuginfo-without-sources lammps-openmpi-debuginfo.x86_64: E: useless-provides debuginfo(build-id) lammps-openmpi-debuginfo.x86_64: E: debuginfo-without-sources lammps-devel.x86_64: W: spelling-error %description -l en_US biomolecules -> bio molecules, bio-molecules, molecules lammps-devel.x86_64: W: spelling-error %description -l en_US mesoscopic -> microscopic lammps-devel.x86_64: W: spelling-error %description -l en_US meso -> mes, meson, mess lammps-devel.x86_64: W: only-non-binary-in-usr-lib lammps-devel.x86_64: W: no-documentation lammps-mpich.x86_64: W: spelling-error %description -l en_US biomolecules -> bio molecules, bio-molecules, molecules lammps-mpich.x86_64: W: spelling-error %description -l en_US mesoscopic -> microscopic lammps-mpich.x86_64: W: spelling-error %description -l en_US meso -> mes, meson, mess lammps-mpich.x86_64: W: unused-direct-shlib-dependency /usr/lib64/mpich/lib/liblammps.so.0 /usr/lib64/mpich/lib/libmpicxx.so.12 lammps-mpich.x86_64: W: unused-direct-shlib-dependency /usr/lib64/mpich/lib/liblammps.so.0 /lib64/libquadmath.so.0 lammps-mpich.x86_64: W: shared-lib-calls-exit /usr/lib64/mpich/lib/liblammps.so.0 exit@GLIBC_2.2.5 lammps-mpich.x86_64: W: no-documentation lammps-mpich.x86_64: E: library-without-ldconfig-postin /usr/lib64/mpich/lib/liblammps.so.0 lammps-mpich.x86_64: E: library-without-ldconfig-postun /usr/lib64/mpich/lib/liblammps.so.0 lammps-mpich-devel.x86_64: W: spelling-error %description -l en_US biomolecules -> bio molecules, bio-molecules, molecules lammps-mpich-devel.x86_64: W: spelling-error %description -l en_US mesoscopic -> microscopic lammps-mpich-devel.x86_64: W: spelling-error %description -l en_US meso -> mes, meson, mess lammps-mpich-devel.x86_64: W: only-non-binary-in-usr-lib lammps-mpich-devel.x86_64: W: no-documentation lammps-openmpi-devel.x86_64: W: spelling-error %description -l en_US biomolecules -> bio molecules, bio-molecules, molecules lammps-openmpi-devel.x86_64: W: spelling-error %description -l en_US mesoscopic -> microscopic lammps-openmpi-devel.x86_64: W: spelling-error %description -l en_US meso -> mes, meson, mess lammps-openmpi-devel.x86_64: W: only-non-binary-in-usr-lib lammps-openmpi-devel.x86_64: W: no-documentation 11 packages and 0 specfiles checked; 9 errors, 42 warnings. Requires -------- lammps-openmpi (rpmlib, GLIBC filtered): libc.so.6()(64bit) libfftw3.so.3()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_4.0.0)(64bit) libgfortran.so.4()(64bit) libgfortran.so.4(GFORTRAN_7)(64bit) libjpeg.so.62()(64bit) libjpeg.so.62(LIBJPEG_6.2)(64bit) liblammps.so.0()(64bit)(openmpi-x86_64) libm.so.6()(64bit) libmpi.so.20()(64bit)(openmpi-x86_64) libmpi_cxx.so.20()(64bit)(openmpi-x86_64) libpng16.so.16()(64bit) libpng16.so.16(PNG16_0)(64bit) libpython3.6m.so.1.0()(64bit) libquadmath.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.8)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libz.so.1()(64bit) rtld(GNU_HASH) lammps-debuginfo (rpmlib, GLIBC filtered): lammps-headers (rpmlib, GLIBC filtered): lammps (rpmlib, GLIBC filtered): /sbin/ldconfig libc.so.6()(64bit) libfftw3.so.3()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_4.0.0)(64bit) libgfortran.so.4()(64bit) libgfortran.so.4(GFORTRAN_7)(64bit) libjpeg.so.62()(64bit) libjpeg.so.62(LIBJPEG_6.2)(64bit) liblammps.so.0()(64bit) libm.so.6()(64bit) libpng16.so.16()(64bit) libpng16.so.16(PNG16_0)(64bit) libpython3.6m.so.1.0()(64bit) libquadmath.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.8)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libz.so.1()(64bit) rtld(GNU_HASH) python3-lammps (rpmlib, GLIBC filtered): lammps(x86-64) python(abi) python3 lammps-devel (rpmlib, GLIBC filtered): lammps(x86-64) lammps-headers(x86-64) liblammps.so.0()(64bit) lammps-mpich (rpmlib, GLIBC filtered): libc.so.6()(64bit) libfftw3.so.3()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_4.0.0)(64bit) libgfortran.so.4()(64bit) libgfortran.so.4(GFORTRAN_7)(64bit) libjpeg.so.62()(64bit) libjpeg.so.62(LIBJPEG_6.2)(64bit) liblammps.so.0()(64bit)(mpich-x86_64) libm.so.6()(64bit) libmpi.so.12()(64bit)(mpich-x86_64) libmpicxx.so.12()(64bit)(mpich-x86_64) libpng16.so.16()(64bit) libpng16.so.16(PNG16_0)(64bit) libpython3.6m.so.1.0()(64bit) libquadmath.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.8)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libz.so.1()(64bit) rtld(GNU_HASH) lammps-mpich-devel (rpmlib, GLIBC filtered): lammps-headers(x86-64) lammps-mpich(x86-64) liblammps.so.0()(64bit)(mpich-x86_64) mpich lammps-openmpi-devel (rpmlib, GLIBC filtered): lammps-headers(x86-64) lammps-openmpi(x86-64) liblammps.so.0()(64bit)(openmpi-x86_64) openmpi Provides -------- lammps-openmpi: lammps-openmpi lammps-openmpi(x86-64) liblammps.so.0()(64bit)(openmpi-x86_64) lammps-debuginfo: debuginfo(build-id) lammps-debuginfo lammps-debuginfo(x86-64) lammps-headers: lammps-headers lammps-headers(x86-64) lammps: lammps lammps(x86-64) liblammps.so.0()(64bit) python3-lammps: python3-lammps python3-lammps(x86-64) lammps-devel: lammps-devel lammps-devel(x86-64) lammps-mpich: lammps-mpich lammps-mpich(x86-64) liblammps.so.0()(64bit)(mpich-x86_64) lammps-mpich-devel: lammps-mpich-devel lammps-mpich-devel(x86-64) lammps-openmpi-devel: lammps-openmpi-devel lammps-openmpi-devel(x86-64) Source checksums ---------------- https://github.com/lammps/lammps/archive/patch_11Aug2017.tar.gz#/lammps-patch_11Aug2017.tar.gz : CHECKSUM(SHA256) this package : 0b643650c5cc33f63b7200d786a990a503482d9c762af24c3176877498b3a5dd CHECKSUM(SHA256) upstream package : 0b643650c5cc33f63b7200d786a990a503482d9c762af24c3176877498b3a5dd Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1474958 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api, C/C++ Disabled plugins: Java, SugarActivity, fonts, Haskell, Ocaml, Perl, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
