https://bugzilla.redhat.com/show_bug.cgi?id=1475763 --- Comment #4 from Fabio Valentini <decathorpe@xxxxxxxxx> --- There are two small issues with the .spec file: 1) According to the changed Versioning guidelines (that gofed hasn't yet been adapted to comply with), the snapshot _DATE_ must be also part of the Release string. So, change the Release line to: Release: 0.1.%{commitdate}.git%{shortcommit}%{?dist} and add a "%global commitdate 20161121" to the definitions at the beginning of the spec file (also, dont forget to update this when doing snapshot updates later). You will also have to adapt the version-release number in the changelog entry. 2) The manually created "testdata" directory is unowned. Add a %dir %{gopath}/src/%{provider}.%{provider_tld}/%{project}/testdata entry to the -unit-test-devel subpackage (please double-check that string for typos on my side). Otherwise, the .spec file (except for copying the testdata manually, which is necessary) corresponds exactly with the template that gofed generates, and is thus generally acceptable. Once those two issues are fixed (you don't have to bump the release from 1 to 2, it's not required from my side), I'll approve the package. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
