[Bug 1482202] Review Request: dbus-broker - Linux D-Bus Message Broker

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1482202



--- Comment #6 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> ---
> jsynacek: This should be fixed. Please, remove the BuildRequires: gcc from the spec.

That's obsolete advice. gcc must be listed. See
https://fedoraproject.org/wiki/Packaging:Guidelines#Build-Time_Dependencies_.28BuildRequires.29.

> Why does the build require systemd and systemd-devel?

One for rpm macros, the other for systemd libs. Requiring both is OK.

> [ ]: Spec use %global instead of %define unless justified.

Right. Replace all %define:s with %global:s.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux