https://bugzilla.redhat.com/show_bug.cgi?id=1482055 Robert-André Mauchin <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |zebob.m@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |zebob.m@xxxxxxxxx Flags| |fedora-review? --- Comment #1 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- Hello, There are several issues with your package: - First the licence is wrong, I can't find GPL anywhere, instead upstream list a mix of MIT and BSD (for tinysvcmdns.c). See https://github.com/mikebrady/shairport-sync/blob/master/LICENSES . It should be reflected and detailed in the SPEC (i.e. which parts are MIT, which parts are BSD). - LICENSES should be listed in %files under %license, not %doc - %doc AUTHORS LICENSES README.md → AUTHORS is empty, don't include it. - %doc should also include RELEASENOTES.md and TROUBLESHOOTING.md - the %changelog is wrong: the version should be in the format %version-%release For example: 3.0-1 Also your package says you are packaging 3.0, but your changelog stops at 2.8.6. And you haven't added your own name either. - You should package the latest stable version, which is 3.1 according to https://github.com/mikebrady/shairport-sync/releases - you shoud use pkgconfig for your libraries: pkgconfig(libconfig) pkgconfig(popt) pkgconfig(openssl) pkgconfig(libdaemon) pkgconfig(avahi-core) pkgconfig(alsa) pkgconfig(soxr) - The Group: tag is not needed in Fedora, please remove it. See https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections - Source0 should be changed to: Source0: https://github.com/mikebrady/%{name}/archive/%{version}/%{name}-%{version}.tar.gz - make %{?_smp_mflags} should be replace with %make_build - make install DESTDIR=%{buildroot} should be replaced with %make_install - You're installing a systemd service file. There are special requirements for those. First you must have a BR on systemd with the following macro: %{?systemd_requires} BuildRequires: systemd Second you must add scriplets in %post, %preun, %postun. See https://fedoraproject.org/wiki/Packaging:Scriptlets?rd=Packaging:ScriptletSnippets#Systemd %post %systemd_post %{name}.service %preun %systemd_preun %{name}.service %postun %systemd_postun_with_restart %{name}.service Btw, systemd-units should not be a BR. - You shouldn't Requires lib dependencies, dnf will automatically detects them. so no need for alsa-lib, libdaemon, libpopt-dev, openssl, avahi and soxr - Your description lines are too long, you should split them before 80 characters - Release should have a dist tag: Release: 1%{?dist} - You shouldn't+++ mix both $RPM_BUILD_ROOT and %{buildroot}. Choose one and stick with it. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
