[Bug 1479027] Review Request: golang-github-golang-image - Go supplementary image libraries

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1479027



--- Comment #14 from Fabio Valentini <decathorpe@xxxxxxxxx> ---
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- Package does not contain duplicates in %files.
  Note: warning: File listed twice:
  /usr/share/gocode/src/golang.org/x/image/font/testdata/CFFTest.otf
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles
- Spec file as given by url is not the same as in SRPM.

No rpmlint messages.

Otherwise:

[x]: Package complies to the Packaging Guidelines


Please fix the last remaining duplicate in %files, and make sure to submit/link
the right version of the package / .spec (with all the fixes from the first
and! second round of improvements).

One question remains: Are the testdata (pictures? fonts?) distributed under an
acceptable license? Some at least seem to be in the Public Domain. You should
include a "License: SOMETHING" tag in the -unit-test-devel subpackage if the
test data is under a different license than the code.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux