https://bugzilla.redhat.com/show_bug.cgi?id=1463492 Athos Ribeiro <athoscribeiro@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |athoscribeiro@xxxxxxxxx, | |jchaloup@xxxxxxxxxx Flags| |needinfo?(jchaloup@redhat.c | |om) --- Comment #22 from Athos Ribeiro <athoscribeiro@xxxxxxxxx> --- Hello, - You may want to check [1] for some guidelines on packaging go programs. In special, you want to use ExclusiveArch: %{go_arches} to make sure it only builds for the arches supported by Fedora and BuildRequires: compiler(go-compilers). Then you can also use the %gobuild and %gotest macros. - You are not supposed to download anything during your build (golang is not an exception). - I'd recommend using gofed [1] to generate a first version of your package and start improving/cleaning from there. - About bundling: I see different opinions on bundling project dependencies for golang projects, and I do understand how bad it is to handle all those dependencies on specific revisions. Fedora packaging guidelines are clear on that matter though: we should avoid it at all costs. Remember now we use pagure to maintain our spec files and you can always send pull requests to package maintainers to update those. Maybe some more experienced golang packager could give some input on this matter here, Jan, any inputs? [1] https://fedoraproject.org/wiki/PackagingDrafts/Go [2] https://github.com/ingvagabund/gofed -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
