[Bug 1482095] Review Request: arduino-listSerialPortsC - Simple multiplatform program to list serial ports with vid /pid/iserial fields

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1482095

Neal Gompa <ngompa13@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #2 from Neal Gompa <ngompa13@xxxxxxxxx> ---
Review notes:

* Package is named correctly
* Package builds and installs correctly
* Package follows general packaging guidelines correctly
* rpmlint produced errors

rpmlint errors:
arduino-listSerialPortsC.x86_64: E: arch-dependent-file-in-usr-share
/usr/share/arduino/lib/liblistSerialsj.so

This is as intended, so I'm going to ignore it.


Issues to fix on import:
* Changelog entry has the wrong version reference

Otherwise, looks good. Please fix the changelog entry on import.

PACKAGE APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux