https://bugzilla.redhat.com/show_bug.cgi?id=1463492 --- Comment #15 from srakitnican <samuel.rakitnican@xxxxxxxxx> --- The newer SPEC file doesn't have changelog entry for the new package release 0.5-1 . (In reply to Dan Williams from comment #12) > Samuel, any chance you could look at the latest files? Is there anything > left to do on this review? Thanks! The major concern I have is that build system is trying to connect to download some stuff. No package should do that, I think Go is no exception to that. Trying to build in mock gives following. + export GOPATH=/builddir/build/BUILD/koko-0.5/_build:/usr/share/gocode + GOPATH=/builddir/build/BUILD/koko-0.5/_build:/usr/share/gocode + cd ./_build/src/github.com/redhat-nfvpe/koko + go get . # cd .; git clone https://github.com/MakeNowJust/heredoc /builddir/build/BUILD/koko-0.5/_build/src/github.com/MakeNowJust/heredoc Cloning into '/builddir/build/BUILD/koko-0.5/_build/src/github.com/MakeNowJust/heredoc'... fatal: unable to access 'https://github.com/MakeNowJust/heredoc/': Could not resolve host: github.com package github.com/MakeNowJust/heredoc: exit status 128 # cd .; git clone https://github.com/mattn/go-getopt /builddir/build/BUILD/koko-0.5/_build/src/github.com/mattn/go-getopt Cloning into '/builddir/build/BUILD/koko-0.5/_build/src/github.com/mattn/go-getopt'... fatal: unable to access 'https://github.com/mattn/go-getopt/': Could not resolve host: github.com package github.com/mattn/go-getopt: exit status 128 # cd .; git clone https://github.com/containernetworking/plugins /builddir/build/BUILD/koko-0.5/_build/src/github.com/containernetworking/plugins Cloning into '/builddir/build/BUILD/koko-0.5/_build/src/github.com/containernetworking/plugins'... fatal: unable to access 'https://github.com/containernetworking/plugins/': Could not resolve host: github.com package github.com/containernetworking/plugins/pkg/ns: exit status 128 # cd .; git clone https://github.com/docker/docker /builddir/build/BUILD/koko-0.5/_build/src/github.com/docker/docker Cloning into '/builddir/build/BUILD/koko-0.5/_build/src/github.com/docker/docker'... fatal: unable to access 'https://github.com/docker/docker/': Could not resolve host: github.com package github.com/docker/docker/client: exit status 128 # cd .; git clone https://github.com/vishvananda/netlink /builddir/build/BUILD/koko-0.5/_build/src/github.com/vishvananda/netlink Cloning into '/builddir/build/BUILD/koko-0.5/_build/src/github.com/vishvananda/netlink'... fatal: unable to access 'https://github.com/vishvananda/netlink/': Could not resolve host: github.com package github.com/vishvananda/netlink: exit status 128 package golang.org/x/net/context: unrecognized import path "golang.org/x/net/context" (https fetch: Get https://golang.org/x/net/context?go-get=1: http: error connecting to proxy http://192.168.1.20:3128: dial tcp 192.168.1.20:3128: connect: network is unreachable) RPM build errors: error: Bad exit status from /var/tmp/rpm-tmp.DiTGyX (%build) Bad exit status from /var/tmp/rpm-tmp.DiTGyX (%build) ERROR: Exception(/tmp/koko-0.5-1.src.rpm) Config(fedora-25-x86_64) 8 minutes 52 seconds INFO: Results and/or logs in: /var/lib/mock/fedora-25-x86_64/result ERROR: Command failed: # /usr/bin/systemd-nspawn -q -M c63079181aa34148b2ac4a6345bb189c -D /var/lib/mock/fedora-25-x86_64/root -a --private-network --setenv=TERM=vt100 --setenv=HOSTNAME=mock --setenv=SHELL=/bin/bash --setenv=LANG=en_US.UTF-8 --setenv=PATH=/usr/bin:/bin:/usr/sbin:/sbin --setenv=http_proxy=http://192.168.1.20:3128 --setenv=PS1=<mock-chroot> \s-\v\$ --setenv=HOME=/builddir --setenv=PROMPT_COMMAND=printf "\033]0;<mock-chroot>\007" -u mockbuild bash --login -c /usr/bin/rpmbuild -bb --target x86_64 --nodeps /builddir/build/SPECS/koko.spec Also rpmlint output: $ rpmlint /tmp/koko-0.5-1.src.rpm koko.src: W: summary-not-capitalized C koko, container connector koko.src: W: name-repeated-in-summary C koko koko.src: W: spelling-error %description -l en_US netns -> nets, net's koko.src: W: spelling-error %description -l en_US veth -> vet, vetch, vets koko.src: W: spelling-error %description -l en_US vxlan -> vanilla koko.src: E: unknown-key RSA#2ec405fb (MD5 1 packages and 0 specfiles checked; 1 errors, 5 warnings. First two could be fixed easily by omitting the name in summary, and capitalizing the first character in sentence. For the 3rd, 4th and 5th please double check the spellings. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
