https://bugzilla.redhat.com/show_bug.cgi?id=1479027 --- Comment #10 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Initial comments: 1) There are some minor typos / spelling errors which you might want to correct (line 44: provite->provide, line 275: skiping-> skipping). 2) Since you are packaging this go library for two import paths, I guess that both are used by dependencies. In this case, using two -devel subpackages seems reasonable. 3) There are some empty conditionals leftover from the gofed template. You can leave them in with comments that they might be needed one day, or just remove them. 4) "%global devel_prefix x" this isn't needed anywhere. 5) It looks like most/all of the testdata is listed in %files sections multiple times ("warning: File listed twice:" warnings in the koji build logs). You might want to look at the %install script to find out how this happens. By the way, you don't have to bump the Release tag for me if you fix minor things I pointed out above. I will provide a more comprehensive review (with fedora-review's help) once the golang-googlecode-text package update will hit the rawhide repo mirrors. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
