https://bugzilla.redhat.com/show_bug.cgi?id=1426465 Mamoru TASAKA <mtasaka@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtasaka@xxxxxxxxxxxxxxxxx --- Comment #9 from Mamoru TASAKA <mtasaka@xxxxxxxxxxxxxxxxx> --- By the way: * Latest version - 0.10 is now available. * License tag - Although "README.md" says this is under LGPLv2+, "mainpage.dox" says this is under LGPLv2. While this needs clarification, currently the rpm license tag must be "LGPLv2", which is safer. * Forbidden code https://fedoraproject.org/wiki/Packaging:SourceURL#When_Upstream_uses_Prohibited_Code - I think the license terms in bindings/matlab/*.m (e.g. bindings/matlab/iio_sys_obj.m): ------------------------------------- % - Use of the software either in source or binary form or filter designs % resulting from the use of this software, must be connected to, run % on or loaded to an Analog Devices Inc. component. ------------------------------------- is non-free license limitation and unacceptable for Fedora. If these files are not actually used, remove these files from source rpm (not only from binary rpm) and repackage tarball. * Compiler https://fedoraproject.org/wiki/Packaging:C_and_C%2B%2B - When using C compiler, "BuildRequires: gcc" (or something) is now *MUST*. * _noarch_ package dependency - Currently build fails: https://koji.fedoraproject.org/koji/taskinfo?taskID=21239042 ------------------------------------- BuildError: The following noarch package built differently on different architectures: python3-iio-0.9-1.fc27.noarch.rpm rpmdiff output was: removed REQUIRES libiio(x86-64) = 0.9-1.fc27 added REQUIRES libiio(ppc-64) = 0.9-1.fc27 ------------------------------------- _noarch_ package must not have arch-specific dependency. This means that python3-iio subpackage must not have %{?_isa} specific Requires, which introduces arch-specific Requires dependency. * Directory ownership https://fedoraproject.org/wiki/Packaging:Guidelines#File_and_Directory_Ownership - /usr/lib/python3.6/site-packages/__pycache__ is already owned by system-python-libs. python3-iio must not own this directory. * Documentation installation https://fedoraproject.org/wiki/Packaging:Guidelines#Documentation - Quote: ------------------------------------- use of %doc with relative paths and installation of files directly into %_pkgdocdir in the same source package is forbidden. ------------------------------------- This means that you must not use %doc README.md (this is relative) and %doc %{_docdir}/%{name}/html (actually using %_pkgdocdir, this is absolute) in the same source rpm, because actually this has caused many troubles in the past and now packaging guideline explicitly forbit this usage. You must choose either of the below: 1. cp README.md into %{buildroot}%{_pkgdocdir} at %install manually 2. rm -rf %{buildroot}%{_pkgdocdir} at %install, and use %doc html/ (relative). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
