https://bugzilla.redhat.com/show_bug.cgi?id=1404895 --- Comment #9 from Robert Scheck <redhat-bugzilla@xxxxxxxxxxxx> --- (In reply to Robert-André Mauchin (afk until next Thu) from comment #8) > - The Group: tag is not used on Fedora. See > https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections RHEL/CentOS 6 still uses the Group: tag by default, I could wrap it like: %if 0%{?rhel} < 7 Group: … %endif > - You should provide a patch to fix the incorrect FSF addresses where > needed. You noticed the mentioned upstream ticket which also references a patch suggestion by (another) Fedora contributor? > - The licence tag is incorrect, there's a wide variety of licences used in > this package and it should be reflected in the tag and detailed. For > reference: > > *No copyright* GPL (with incorrect FSF address) > ----------------------------------------------- > partclone-0.3.5a/src/btrfs/commands.h This is GPLv2, not GPL+. > BSD (3 clause) > -------------- > partclone-0.3.5a/src/ufs/ffs/fs.h > partclone-0.3.5a/src/ufs/sys/disklabel.h > partclone-0.3.5a/src/ufs/ufs/dinode.h > partclone-0.3.5a/src/ufs/ufs/fs.h > > BSD (unspecified) > ----------------- > partclone-0.3.5a/src/ufs/libufs.h This path of the source tree is not used/not built. > GPL (v3 or later) > ----------------- > partclone-0.3.5a/fail-mbr/fail-mbr.S > partclone-0.3.5a/gitlog-to-changelog > partclone-0.3.5a/src/ntfsfixboot.c Binary file fail-mbr* is raised in comment #2, gitlog-to-changelog is not being used. > GPL (with incorrect FSF address) > -------------------------------- > partclone-0.3.5a/src/btrfs/btrfs-list.c […] > partclone-0.3.5a/src/btrfs/volumes.h This is GPLv2, not GPL+. How about: GPL+ and GPLv2 and GPLv2+ and GPLv3+ and LGPLv2 and LGPLv2+ Or, to respect partclone.<filesystem>, more in detail: (GPLv2+ and LGPLv2+) and (GPLv2+ and GPLv2 and GPL+ and LGPLv2 and LGPLv2+) and (GPLv2+ and GPLv2 and LGPLv2+) and (GPLv2+ and GPLv3+ and LGPLv2+) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
