[Bug 1474958] Review Request: lammps - Large-scale Atomic/ Molecular Massively Parallel Simulator

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1474958



--- Comment #3 from Christoph Junghans <junghans@xxxxxxxxx> ---
Thanks for the review!

(In reply to Antonio Trande from comment #2)
> Initial comments:
> 
> %if 0%{?fedora} > 12 || 0%{?rhel} > 6
> %global with_python3 1
> %else
> %{!?python_sitearch: %global python_sitearch %(%{__python} -c "from
> distutils.sysconfig import get_python_lib; print get_python_lib(1)")}
> %endif
> 
> '%global with_python3 1' is used for ??
> On Fedora, do you want provide python2 or python3 or both wrappers?
Honestly lammps.py works with both, so should I just install 2 same files
twice?
> 
> - For epel6 use macros reported in
> https://fedoraproject.org/wiki/EPEL:Packaging#Python.
> 
> - Install '*.py*' files separately in 'python?-lammps' packages.
ok

> 
> - Install MPI libraries and header files separately in their own packages:
> 
> lammps
> lammps-devel (unversiond libs + header files)
> lammps-openmpi
> lammps-openmpi-devel (OpenMPI unversiond libs + header files)
> lammps-mpich
> lammps-mpich-devel (MPICH unversiond libs + header files)
There are no MPI-specific headers, so lammps-*mpi*-devel would only contain the
libs and would be useless without the devel package, so I put them into one.

It seems https://fedoraproject.org/wiki/Packaging:MPI suggested to use a
lammps-headers package for that case.

> 
> - For epel* use 'BuildRequires: cmake3'
I haven't really starting working on epel7 support yet, but I wlll push that
in.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux