https://bugzilla.redhat.com/show_bug.cgi?id=1477363 --- Comment #8 from Richard W.M. Jones <rjones@xxxxxxxxxx> --- > %define libname ... I believe that all %define should be %global because of a weirdness of RPM (https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#.25global_preferred_over_.25define) > # make build-native-dynlink; "make install" does it by default, not sure if > # should be done here. I'm guessing it should be done there. Also note the %{ocaml_natdynlink} macro which expands to the list of architectures that support natdynlink (≠ list of architectures supporting native compilation). In addition, fedora-review complains about: > [ ]: License field in the package spec file matches the actual license. > Note: Checking patched sources after %prep for licenses. Licenses > found: "ISC", "Unknown or generated", "*No copyright* Public domain". > 34 files have unknown license. Detailed output of licensecheck in > [...] As long as MIT is compatible with the license, then that's fine. > [!]: Uses parallel make %{?_smp_mflags} macro. Not all packages are compatible with parallel builds, but you should check to see if it can be used and add a comment to the spec file if there is a problem. > [ ]: Spec use %global instead of %define unless justified. > Note: %define requiring justification: %define libname %(echo %{name} > | sed -e 's/^ocaml-//') See above. There are also some rpmlint errors, but they all seem to be irrelevant. Generated dependencies look fine to me. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
