https://bugzilla.redhat.com/show_bug.cgi?id=1469726 --- Comment #7 from Raphael Groner <projects.rg@xxxxxxxx> --- (In reply to Zbigniew Jędrzejewski-Szmek from comment #6) > > # need Linux kernel version 2.6.37.1 or better to use zram > > Requires: kernel >= 2.6.37.1 > > First, nowadays kernel has been split into kernel-core and other > subpackages, so you can easily boot a machine without kernel.rpm (which also > pulls in kernel-modules). Second, the fact that you have a specific > kernel.rpm installed does not mean that you're running with that version so > this is not effective. And third, there's no way to install a kernel rpm for > 2.6.x in any Fedora. So you should just drop this line. OK. Good point about several kernels available to boot on a system. > > BuildRequires: systemd-units > > > Requires(post): systemd-sysv > > Requires(post): systemd-units > > Requires(preun): systemd-units > > Requires(postun): systemd-units > > Requires: systemd > > Requires: initscripts > > This should be replaced by > %{?systemd_requires} > BuildRequires: systemd > [https://fedoraproject.org/wiki/Packaging:Scriptlets#Systemd] OK > > %systemd_postun_with_restart mkzram.service > Hmm, that could be dangerous. Disabling swap during an upgrade could bring > the machine down. %systemd_postun seems more reasonable. OK > > After=multi-user.target > That's certainly the wrong place to order this. Not only it causes a > dependency loop with swap.target which is ordered much earlier, it might > also disable swap at the beginning of shutdown, crashing the machine. Drop it? > > sleep 1 > Hmm. swapoff is synchronous so this is either masking a bug in the kernel or > just plain unnecessary. Drop it? > I'm not particularly impressed by how this is all put together. The problem > starts with the stupid kernel interface which requires ~50 lines of shell to > bring up swap. That's just bizarre. But anyway, zram is useful, so we should > make it easy to use, so I think it's worth to package this, so it'd be great > to finally get this package into Fedora. How can they talk on reddit about available systemd integration without an official package? Is this review still needed? https://www.reddit.com/r/Fedora/comments/4y6n5t/how_to_enable_zram_on_fedora_24/ What about storaged-zram? Is it stilled developed? I see it's part of general storaged, merged into systemd or somehow actual plans to merge. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
