[Bug 1474033] Review Request: ucx - Communication library implementing high-performance messaging

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1474033



--- Comment #10 from Michael Schwendt <bugs.michael@xxxxxxx> ---
> Static libs moved to separate -static package. -devel depends on it.

That is not what the guidelines suggest. Just think about it a bit. Such a
dependency defeats the purpose of moving the static libs into a _separate_
package.


> Added --disable-rpath to %configure anyway.

That's a no-op, if the configure script doesn't support that option [yet]:

| configure: WARNING: unrecognized options: --disable-rpath


> %files
> ...
> %{_datadir}/ucx
> %exclude %{_datadir}/ucx/examples
> %{_datadir}/ucx/perftest

The first line in the quote above includes the complete %_datadir/ucx/ tree
already minus the excluded directory. Hence the last line is superfluous.


> Just want to have issues in spec fixed before creating actual release.
> Can we ignore this one for a while?

You only need to keep in mind that replacing the source tarball with another
release could be a rather disruptive step during review.


Btw, the build.log contains several warnings about libraries and tools
(doxygen!) it cannot find.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux