[Bug 1477363] Review Request: ocaml-cmdliner - Declarative definition of command line interfaces for OCaml

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1477363



--- Comment #3 from Richard W.M. Jones <rjones@xxxxxxxxxx> ---
> %global opt %(test -x %{_bindir}/ocamlopt && echo 1 || echo 0)

Don't use this test.  Instead use the %{ocaml_native_compiler} macro
which lists arches that support the native compiler.  You use it like this:

  %ifarch %{ocaml_native_compiler}
  ... stuff needing ocamlopt ...
  %endif

> %global debug_package %{nil}

Most packages can create debuginfo.  Make sure that -g is passed to
every invocation of ocamlc, ocamlopt, ocamlmklib (and maybe others).

> %global _use_internal_dependency_generator 0
> %global __find_requires /usr/lib/rpm/ocaml-find-requires.sh
> %global __find_provides /usr/lib/rpm/ocaml-find-provides.sh

These lines are almost certainly wrong, just remove them.

Yes, I'm aware that the OCaml packaging guidelines are some distance
behind actual practice.  If you want to volunteer to update them ...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux