https://bugzilla.redhat.com/show_bug.cgi?id=1421046 Robert-André Mauchin <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@xxxxxxxxx --- Comment #5 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- Hello, I think you should use the gofed script as your basis and not go too far away from this script. For example, your Provides should list all the libraries provided by the package: Provides: golang(%{import_path}) = %{version}-%{release} Provides: golang(%{import_path}/app) = %{version}-%{release} Provides: golang(%{import_path}/appinfo) = %{version}-%{release} Provides: golang(%{import_path}/appinfo/desktopappinfo) = %{version}-%{release} Provides: golang(%{import_path}/arch) = %{version}-%{release} Provides: golang(%{import_path}/archive) = %{version}-%{release} Provides: golang(%{import_path}/archive/gzip) = %{version}-%{release} Provides: golang(%{import_path}/archive/utils) = %{version}-% and so on. Otherwise golang packages using this library won't be able to find their dependencies. By the way, this is a problem you have on your other golang libraries you have on your COPR. If you intend to submit them, I recommend you to start with the basis of the gofed script and then fix whatever issue remains. Also you have no %check for this library. This is highly recommended. Don't forget to add the various testdata to your unit-test-devel.file-list. For example: # pack testdata for file in $(find */*testdata */*/testdata) ; do dirprefix=$(dirname $file) install -d -p %{buildroot}/%{gopath}/src/%{import_path}/$dirprefix cp -pav $file %{buildroot}/%{gopath}/src/%{import_path}/$file echo "%%{gopath}/src/%%{import_path}/$file" >> unit-test-devel.file-list done You'll some BR for the tests, there are specified in the README.md. Shortlist: # Required for tests BuildRequires: dbus-x11 BuildRequires: pkgconfig(gdk-pixbuf-xlib-2.0) BuildRequires: pkgconfig(libpulse) BuildRequires: pkgconfig(libcanberra) BuildRequires: mobile-broadband-provider-info If some checks fail and you don't know why, best is to report them upstream and deactivate them with the bugreport url in comment. This shouldn't be a noarch, you should use the ExclusiveArch for Go: ExclusiveArch: %{?go_arches:%{go_arches}}%{!?go_arches:%{ix86} x86_64 aarch64 %{arm}} And BR the right compiler: BuildRequires: %{?go_compiler:compiler(go-compiler)}%{!?go_compiler:golang} -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
