https://bugzilla.redhat.com/show_bug.cgi?id=1476590 Robert-André Mauchin <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@xxxxxxxxx --- Comment #3 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- Hello, A couple of preliminary remarks: - You shouldn't request golang dependencies directly like this, but instead use a construct like: golang(import_path). See below. - You should not use go get …, you should add all the Golang dependencies directly to your BR. Here's the full list you need: BuildRequires: golang(github.com/BurntSushi/xgb) BuildRequires: golang(github.com/BurntSushi/xgbutil) BuildRequires: golang(github.com/howeyc/fsnotify) BuildRequires: golang(golang.org/x/image) BuildRequires: golang(gopkg.in/alecthomas/kingpin.v2) BuildRequires: golang(github.com/BurntSushi/freetype-go) BuildRequires: golang(github.com/BurntSushi/graphics-go) BuildRequires: golang(github.com/axgle/mahonia) BuildRequires: golang(github.com/msteinert/pam) BuildRequires: golang(github.com/nfnt/resize) - Golang is not available on all arches, thus you need an ExclusiveArch: ExclusiveArch: %{?go_arches:%{go_arches}}%{!?go_arches:%{ix86} x86_64 aarch64 %{arm}} (Please update to the latest go-srpm-macros from rawhide if you do a Koji build later, otherwise it will fail on ppc64) - You shouldn't do BR: golang but instead: BuildRequires: %{?go_compiler:compiler(go-compiler)}%{!?go_compiler:golang} - There are numerous Golang dependencies I pulled from your COPR, but you should make Review Requests for all of them otherwise it makes it difficult to review such packages. - You could replace these -devel packages with pkgconfig invocation: BuildRequires: pkgconfig(gnome-keyring-1) BuildRequires: pkgconfig(libsystemd) BuildRequires: pkgconfig(poppler-glib) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
