https://bugzilla.redhat.com/show_bug.cgi?id=1344276 --- Comment #29 from Sachidananda Urs <surs@xxxxxxxxxx> --- (In reply to Ken Dreyer from comment #28) > Please accept my apologies for the delay and lack of communication! That is > bad. > > I can continue the review or let someone else take it. > > Looks like the LICENSE file should be listed as %license under %files. > > Would you please use the newer %py2_build and %py2_install macros? > https://fedoraproject.org/wiki/Packaging:Python > > Can this package work with Python 3 instead of Python 2? Maybe it would be a > good idea to add a comment to the .spec file explaining why this will not > work with Python 3 if that is the case. > https://fedoraproject.org/wiki/FinalizingFedoraSwitchtoPython3 is coming > eventually. You could conditionalize py2/py3 with "%if %{?rhel} < 8" if you > want to share the same .spec file across RHEL 7 and Fedora. Ack! Will do that. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
