https://bugzilla.redhat.com/show_bug.cgi?id=1479022 --- Comment #3 from Jaroslav Škarvada <jskarvad@xxxxxxxxxx> --- (In reply to Ye Cheng from comment #1) > (In reply to Jaroslav Škarvada from comment #0) > > This is an unofficial review. > > Issues: > ======= > - All build dependencies are listed in BuildRequires, except for any that > are listed in the exceptions section of Packaging Guidelines. > Note: These BR are not needed: coreutils gcc make > See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 False positives according to current rules all requirements has to be listed. > - Directories without known owners: /usr/lib64/preeny Fixed > Please add %{_libdir}/%{name} to /etc/ld.so.conf.d/ (and run ldconfig) if it > is intended for ld to find the installed libraries. It's not intended, it's meant to be used by LD_PRELOAD > - %build honors applicable compiler flags or justifies otherwise. > Note : %{?__global_ldflags} Linker flag relro and now may alter the > behaviour of the application being debugged but now linker flag could > potentially help to reveal the issue earlier. Addition of > LDFLAGS="%{?__global_ldflags}" doesn't break the compilation. Fixed > - %check is present and all tests pass. > Upstream shipped 3 tests in /tests directory. They are not tests, but more like examples, i.e. there is no test/check rule in the Makefiles, it can just compile the sources in the tests directory, some test logic has to be written. Also I think this "examples" are useless for regular user, thus not including them. > - Requires correct, justified where necessary. > libini_config is required (but not listed) at runtime. This was caused by wrong build procedure, it should be fixed now and all runtime deps coulb be automatically picked by rpmbuild. New version: Spec URL: https://jskarvad.fedorapeople.org/preeny/preeny.spec SRPM URL: https://jskarvad.fedorapeople.org/preeny/preeny-0.1-2.fc25.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
