[Bug 1476589] Review Request: deepin-api - Go-lang bingding for dde-daemon

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1476589

Ye Cheng <18969068329@xxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |18969068329@xxxxxxx



--- Comment #3 from Ye Cheng <18969068329@xxxxxxx> ---
(In reply to sensor.wen from comment #2)
> SPEC: 
> https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-26-
> x86_64/00586135-deepin-api/deepin-api.spec

>go get github.com/disintegration/imaging \
>    github.com/howeyc/fsnotify \
>    gopkg.in/check.v1 \
>    gopkg.in/alecthomas/kingpin.v2
This will fail the mock build because network access is not available at build
time and these downloaded library become undesirably bundled into the
application.
Reference:http://fedoraproject.org/wiki/Packaging:Guidelines#Build_time_network_access

It seems that github.com/howeyc/fsnotify is no longer actively maintained.
Please switch to golang-github-go-fsnotify-fsnotify package if possible.

>%{_datadir}/icons/hicolor/*/actions/*
If it is necessary for these icon to display properly immediately after
installation, please write a %post script let to refresh icon cache. Please
reference
https://fedoraproject.org/wiki/Packaging:Scriptlets?rd=Packaging:ScriptletSnippets#Icon_Cache
for detail

>%{_unitdir}/*.service
Perhaps some  %post,%preun and %postun script lets are necessary for handling
systemd units. Please reference
http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Systemd

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux