https://bugzilla.redhat.com/show_bug.cgi?id=1476434 --- Comment #8 from Ye Cheng <18969068329@xxxxxxx> --- (In reply to Robin Lee from comment #7) Thank you very much for the review. New spec URL:https://copr-be.cloud.fedoraproject.org/results/yecheng/bstrlib/fedora-rawhide-i386/00586525-bstrlib/bstrlib.spec New srpm URL: https://copr-be.cloud.fedoraproject.org/results/yecheng/bstrlib/fedora-rawhide-i386/00586525-bstrlib/bstrlib-1.0.0-1.fc27.src.rpm > [!]: %build honors applicable compiler flags or justifies otherwise. > Note: Test programs should also honor global flags Tests is now built and executed with make with global flags. Compiler complains about various harmless type mismatches and there is already one pull request (https://github.com/websnarf/bstrlib/pull/16/files) that could fix them but it was not merged into the newest release. > [?]: Cleaning test directory is not necessary. Tests are now built in place and not removed. > [?]: Why separating packages for bstrlib-safe? Since the library is small in > size. Bstrlib-safe package is no longer separated as user can still decide whether to use the safe moduli by simply deciding whether to include its header and link the separately built bstrsafe library. > [?]: Where does SOURCE1 come from? You should add a comment at least. A comment indicating the makefile is packager supplied is added. > [!]: Use tar.gz format instead of zip. Since tar.gz file usually has better > compression radio. Changed to tar.gz file. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
