https://bugzilla.redhat.com/show_bug.cgi?id=1432993 --- Comment #9 from Randy Barlow <randy@xxxxxxxxxxxxxxxxxxxxx> --- Created attachment 1308835 --> https://bugzilla.redhat.com/attachment.cgi?id=1308835&action=edit review.txt There are a couple of things that must be fixed for approval, and a couple of optional suggestions. These two must be fixed: * The package needs to require systemd and logrotate, since it depends on directories provided by those packages. * The changelog's newest entry is for release -2, but the current release is -3. Please ensure that there is a changelog entry for the current release. These are optional: * fedora-review things that the BuildRequire on gcc is not needed. * You could easily eliminate the rpmlint warnings: - Change scsi to SCSI in the description. - Drop the execute bit on the man page. * I recommend sending a patch to upstream to correct the FSF address in the license file. This would fix the rpmlint error. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
