https://bugzilla.redhat.com/show_bug.cgi?id=1424233 --- Comment #3 from c72578@xxxxxxxx --- Hello Ole, here are some comments: - Please remove "Applications/Internet" from spec file, which is deprecated https://fedoraproject.org/wiki/RPMGroups - Source: could be changed from http://people.gnome.org/~ole/%{name}/%{name}-%{version}.tar.xz to https://download.gnome.org/sources/%(name)/10.0/%{name}-%{version}.tar.xz Because the girl git repo is also at the gnome site: https://git.gnome.org/browse/girl/ - Concerning the changelog entries: The dist should not be added after the version in the changelog and the e-mail address is usually included according to Fedora guidelines. https://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs e.g.: * Thu May 04 2017 Ole Aamot - 10.0.0-1.fc25 -> * Thu May 04 2017 Ole Aamot <oka@xxxxxx> - 10.0.0-1 Best regards Wolfgang -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
