https://bugzilla.redhat.com/show_bug.cgi?id=1477567 --- Comment #2 from c72578@xxxxxxxx --- Dear Timothée, thanks for working on a Fedora rpm file of gcolor3. Here are some initial comments: - Please remove "Group: Development/Tools" from spec file, which is deprecated https://fedoraproject.org/wiki/RPMGroups - The license file has to be included separately (not under %doc) %license LICENSE - Could you have a look at the BuildRequires entries and possibly add minimum required versions. What about requirement of perl? configure checks for it: checking for perl >= 5.8.1... 5.24.2 - rpmlint shows the following error: gcolor3.x86_64: E: invalid-appdata-file /usr/share/appdata/gcolor3.appdata.xml When running appstream-util for validation of gcolor3.appdata.xml, I get the following output: appstream-util validate /usr/share/appdata/gcolor3.appdata.xml /usr/share/appdata/gcolor3.appdata.xml: FAILED: • url-not-found : <screenshot> url not found [https://raw.githubusercontent.com/Unia/unia.github.io/hugo/static/images/projects/gcolor3/saved.png] • url-not-found : <screenshot> url not found [https://raw.githubusercontent.com/Unia/unia.github.io/hugo/static/images/projects/gcolor3/picker.png] Validation of files failed This should be fixed/patched, ideally together with upstream and the screenshots saved in a "permanent" location. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
