https://bugzilla.redhat.com/show_bug.cgi?id=1470705 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #3 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL and Source0 addresses are Ok. Source0 archive (SHA-256: ad536c15c4060cd7e81e2f218d7671dc3f2660ee06776543d9465f731482d659) is original. Ok. Summary verified from README. Ok. TODO: The description is about `this module' but the package contains many modules. I recommend to replace it with 'These Perl modules' or `The Log::ger Perl module'. License verified from LICENSE, lib/Log/ger/Heavy.pm and other module files. Ok. No XS code, noarch BuildArch is Ok. FIX: Do not build-require both `perl(Data::Dumper). lib/Log/ger/Util.pm does not use it if Data::Dmp is available. FIX: Build-require `perl(blib)' for tests (t/00-compile.t:32). Pod::Coverage::TrustPod, Test::Pod::Coverage, Test::Perl::Critic, Test::Pod are not used. Ok. All tests pass. Ok. $ rpmlint perl-Log-ger.spec ../SRPMS/perl-Log-ger-0.021-1.fc27.src.rpm ../RPMS/noarch/perl-Log-ger-0.021-1.fc27.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok. File layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Log-ger-0.021-1.fc27.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.26.0) 1 perl(Data::Dmp) >= 0.21 1 perl(Log::ger) 1 perl(Log::ger::Heavy) 1 perl(Log::ger::Plugin) 1 perl(Log::ger::Util) 1 perl(parent) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-Log-ger-0.021-1.fc27.noarch.rpm | sort -f | uniq -c 1 perl(Log::ger) = 0.021 1 perl(Log::ger::Format) = 0.021 1 perl(Log::ger::Format::None) = 0.021 1 perl(Log::ger::Heavy) = 0.021 1 perl(Log::ger::Layout) = 0.021 1 perl(Log::ger::Output) = 0.021 1 perl(Log::ger::Output::Array) = 0.021 1 perl(Log::ger::Output::ArrayML) = 0.021 1 perl(Log::ger::Output::Null) = 0.021 1 perl(Log::ger::Output::String) = 0.021 1 perl(Log::ger::Plugin) = 0.021 1 perl(Log::ger::Plugin::MultilevelLog) = 0.021 1 perl(Log::ger::Util) = 0.021 1 perl-Log-ger = 0.021-1.fc27 Binary provides are Ok. $ resolvedeps f27-build ../RPMS/noarch/perl-Log-ger-0.021-1.fc27.noarch.rpm Binary dependencies resolvable. Ok. The package builds in F27 (https://koji.fedoraproject.org/koji/taskinfo?taskID=21002674). Ok. Otherwise the package is in line with Fedora and Perl packaging guidelines. Please correct the `FIX' items and consider fixing the `TODO' item before building this package. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
